Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintainer field to plugin update #316

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Nov 29, 2023

Changes summary:

  • Replace all Owner appearances with Collaborators, to be consistent with: Replace 'Owners' by 'Collaborators' #254
  • Create a new field maintainer to store the maintainer user. It takes the value from created_by by default. This new field will be displayed as the maintainer in the plugin details.
  • Create a new field display_created_by to display the created_by in the plugin details. This is set to False by default.

Please find below a GIF:
Maintainer_field

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (6fe3124) 82.01% compared to head (a8db7d7) 36.97%.

Files Patch % Lines
qgis-app/plugins/tests/test_change_maintainer.py 36.36% 28 Missing ⚠️
qgis-app/plugins/forms.py 12.50% 7 Missing ⚠️
...s-app/plugins/migrations/0005_plugin_maintainer.py 81.81% 2 Missing ⚠️
qgis-app/plugins/models.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #316       +/-   ##
===========================================
- Coverage   82.01%   36.97%   -45.04%     
===========================================
  Files         139      106       -33     
  Lines        5427     4500      -927     
===========================================
- Hits         4451     1664     -2787     
- Misses        976     2836     +1860     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xpirix Xpirix marked this pull request as ready for review November 30, 2023 10:31
@gacarrillor
Copy link
Member

Thank you, I think it's much clearer now how to set the maintainer 👍 . Let's see what others think.

@gacarrillor
Copy link
Member

Just to mention that this PR will fix both #260 and #303.

@dimasciput dimasciput merged commit 5b3bdd9 into qgis:master Dec 23, 2023
2 checks passed
@Xpirix Xpirix deleted the maintainer_field branch January 2, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants