Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise controller gains when moving to poses #44

Open
btalb opened this issue Mar 25, 2022 · 5 comments
Open

Optimise controller gains when moving to poses #44

btalb opened this issue Mar 25, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@btalb
Copy link
Collaborator

btalb commented Mar 25, 2022

We have gone with conservative controller gains for now, but they could be more aggressive.

Well-tuned gains would mean the robot would move between poses quicker, while still not suffering from overshoot or instabilities.

@btalb btalb self-assigned this Mar 25, 2022
@btalb btalb added the enhancement New feature or request label Mar 25, 2022
@ivbelkin
Copy link

ivbelkin commented Mar 28, 2022

Hello! It looks like I face a problem related to this issue.

When I try to run hello_passive example on the office:1 environment robot stucks (or moves extremely slow) after ~7 route pose.

I start the simulation with the command:
benchbot_run --robot carter_omni --env office:1 --task semantic_slam:passive:ground_truth
and example:
benchbot_submit --example hello_passive

@btalb
Copy link
Collaborator Author

btalb commented Mar 28, 2022

Thanks for reporting @ivbelkin .

Did it finish the run (but extremely slowly), or get stuck and not continue from pose 7?

We will be improving the controller gains within the next couple of days which should make a big difference to speed.

Sorry about this. We had the opposite problem before with instabilities causing crashes, but have gone back the other way a little too far.

@david2611
Copy link
Collaborator

@ivbelkin thanks for the info. I have just checked your problem and can confirm that it is an unrelated issue but one that will be easily fixed in our next update.

The issue is due to a starting pose that is not correct under the omniverse system which throws off all subsequent trajectory points.

If you want to run office:1 before the next update just go to
/path/to/benchbott/addons/benchbot_addons/benchbot-addons/envs_bear_challenge_sim_omni/environments/office_1.yaml
and update the start pose on line 13 to
start_pose: [0.781, 0.0, 0.0, 0.625, -1.0, -9.5, 0.3]

I can warn you that the full trajectory will take a while due to the original issue posted here. Mine took 36 mins. We will keep working to improve this but hopefully this quick fix can sort out your issues with office:1 👍

If it doesn't, please open a new issue and we will get onto it

@ivbelkin
Copy link

@ivbelkin thanks for the info. I have just checked your problem and can confirm that it is an unrelated issue but one that will be easily fixed in our next update.

The issue is due to a starting pose that is not correct under the omniverse system which throws off all subsequent trajectory points.

If you want to run office:1 before the next update just go to /path/to/benchbott/addons/benchbot_addons/benchbot-addons/envs_bear_challenge_sim_omni/environments/office_1.yaml and update the start pose on line 13 to start_pose: [0.781, 0.0, 0.0, 0.625, -1.0, -9.5, 0.3]

I can warn you that the full trajectory will take a while due to the original issue posted here. Mine took 36 mins. We will keep working to improve this but hopefully this quick fix can sort out your issues with office:1 +1

If it doesn't, please open a new issue and we will get onto it

Thank you, it fixes the problem for me too

@btalb
Copy link
Collaborator Author

btalb commented Apr 1, 2022

These values should be better with the release of v2.2.2, but we still aren't quite satisfied.

We will release an update in a few days which should result in quicker traversal times through environments.

btalb added a commit to qcr/benchbot_robot_controller that referenced this issue Apr 27, 2022
btalb added a commit to qcr/benchbot_robot_controller that referenced this issue Apr 27, 2022
btalb added a commit to qcr/benchbot_robot_controller that referenced this issue Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants