Remove **kwargs from prepare_optimizer #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67456352 |
iden-kalemaj
added a commit
to iden-kalemaj/opacus
that referenced
this pull request
Dec 19, 2024
Summary: None of the optimizer classes accept **kwargs, so I am removing **kwargs from perpare_optimizer. Otherwsie, the current code throws an error when creating a custom PrivacyEngine that takes in additional arguments. Differential Revision: D67456352
iden-kalemaj
force-pushed
the
export-D67456352
branch
from
23850b2 to
e8c355b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67456352 |
Summary: None of the optimizer classes accept **kwargs or have special arguments so I am removing **kwargs from optim_class(). Otherwise, the current code throws an error when creating a custom PrivacyEngine that takes in additional arguments. Reviewed By: EnayatUllah Differential Revision: D67456352
iden-kalemaj
force-pushed
the
export-D67456352
branch
from
e8c355b to
10ffbd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67456352 |
|
This pull request has been merged in ed1bd0b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
None of the optimizer classes accept **kwargs, so I am removing **kwargs from perpare_optimizer.
Otherwsie, the current code throws an error when creating a custom PrivacyEngine that takes in additional arguments.
Differential Revision: D67456352