Set up CI #87
Set up CI #87
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
| runner: ["linux.12xlarge"] | ||
| gpu-arch-type: ["cpu"] | ||
| include: | ||
| - python-version: 3.8 |
There was a problem hiding this comment.
I did 3.8 for coverage
| eval "$($(which conda) shell.bash hook)" && conda deactivate && conda activate ci | ||
|
|
||
| echo '::group::Install testing utilities' | ||
| pip install --progress-bar=off pytest pytest-mock pytest-cov expecttest numpy |
| set +x && eval "$($(which conda) shell.bash hook)" && set -x | ||
|
|
||
| # Setup the OS_TYPE environment variable that should be used for conditions involving the OS below. | ||
| case $(uname) in |
There was a problem hiding this comment.
Are you planning to extend CI to other platforms? Because this file seems a lot more general than what we use it for right now?
There was a problem hiding this comment.
Maybe, I'm not sure. Leaving it just in case
|
|
||
| echo '::group::Install PyTorch' | ||
| # TODO: Can we maybe have this as environment variable in the job template? For example, `IS_RELEASE`. | ||
| if [[ (${GITHUB_EVENT_NAME} = 'pull_request' && (${GITHUB_BASE_REF} = 'release'*)) || (${GITHUB_REF} = 'refs/heads/release'*) ]]; then |
There was a problem hiding this comment.
Maybe? We could set up an example binary release for this
| - python-version: 3.8 | ||
| runner: linux.g5.4xlarge.nvidia.gpu | ||
| gpu-arch-type: cuda | ||
| gpu-arch-version: "11.8" |
There was a problem hiding this comment.
I'm not sure this is possible, it depends on what github runners are offered to the pytorch org
|
Re the comments about the github workflows: these are not copy-paste-able for OSS developers because the github workflow only works if you're in the pytorch org. Because of that I'm fine with not having the cleanest setup for now |
Stack from ghstack (oldest at bottom):