Fix posterior method in BatchedMultiOutputGPyTorchModel for tracing JIT
#2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
reviewed
Oct 24, 2024
saitcakmak
reviewed
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2592 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17363 17365 +2
=======================================
+ Hits 17361 17363 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2591. Generates the MTMVN for the independent task case slightly differently when jit traced.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
A unit test
test_posterior_in_trace_modehas been added to test_gpytorch.pyRelated PRs
NA