Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert dora fusion test from pytest to unittest #1622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

osbm
Copy link

@osbm osbm commented Jan 26, 2025

Related to #1321

Thanks

diff is looking crazy, i did some more tests should i add them all or just one by one?

CC: @jerryzh168

Copy link

pytorch-bot bot commented Jan 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1622

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 33b02ee with merge base 47f96f1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2025
@osbm osbm mentioned this pull request Jan 26, 2025
74 tasks
@jerryzh168
Copy link
Contributor

thanks @osbm refactoring the test file one by one sounds reasonable and probably easier to review and manage I think

@osbm osbm requested a review from jerryzh168 January 26, 2025 23:21
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 29, 2025
@jerryzh168
Copy link
Contributor

jerryzh168 commented Jan 29, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants