-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert dora fusion test from pytest to unittest #1622
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1622
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 33b02ee with merge base 47f96f1 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
thanks @osbm refactoring the test file one by one sounds reasonable and probably easier to review and manage I think |
please address https://github.com/pytorch/ao/actions/runs/12979270675/job/36338709239?pr=1622 by manually running https://github.com/pytorch/ao/blob/7b0d2ce50baaa2a137eb9d438a076544c43096a3/scripts/run_ruff_fix.sh or enable |
Related to #1321
Thanks
diff is looking crazy, i did some more tests should i add them all or just one by one?
CC: @jerryzh168