Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phi-3-mini-4k-instruct bfloat16/int8 #195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

makaveli10
Copy link

@makaveli10 makaveli10 commented Aug 20, 2024

Some perf numbers on a single 3090:

  • python generate.py --checkpoint_path checkpoints/microsoft/Phi-3-mini-4k-instruct/model.pth --compile
Bandwidth achieved: 791.61 GB/s
==========
Average tokens/sec: 106.31
Memory used: 8.02 GB
  • python generate.py --checkpoint_path checkpoints/microsoft/Phi-3-mini-4k-instruct/model_int8.pth --compile
Bandwidth achieved: 597.70 GB/s
==========
Average tokens/sec: 160.55
Memory used: 4.70 GB

@facebook-github-bot
Copy link

Hi @makaveli10!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 20, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@zhengpeirong
Copy link

What have you changed???

@makaveli10
Copy link
Author

makaveli10 commented Jan 29, 2025

@zhengpeirong I dont follow? I just added support for compiling phi-3

@zhengpeirong
Copy link

@zhengpeirong I dont follow? I just added support for compiling phi-3

I mean the difference between your files and the original files.

@makaveli10
Copy link
Author

The original files dont support converting the checkpoint and the model architecture is different as well.

@zhengpeirong
Copy link

The original files dont support converting the checkpoint and the model architecture is different as well.

Thanks. It's convenient for the PR merging if you upload the file with the original name. This will automatically compare the commit changes.

@makaveli10
Copy link
Author

I guess its going to be tedious to make support for the phi-3 in the existing files so thats why i created a separate directory with scripts supporting phi-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants