New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lora/model combo preview #423

Open

christian-byrne wants to merge 4 commits into pythongosssss:main from christian-byrne:loader-preview-fix

Contributor

christian-byrne commented Jan 15, 2025

This PR resolves #413 by updating the lora/model combo preview to work with Comfy-Org/litegraph.js#414.

Changes include:

Use constant for width/height of preview image
Attach image preview to body instead of the context menu directly, as the context menu no longer shows overflow
Add mouseenter, mouseleave, and click handlers to manually calculate and update the position/visibility of the preview image

christian-byrne added 4 commits

January 15, 2025 15:08


          Update lora/model preview

08d641d


          Formatting

daa7cdf


          change spaces to tabs

9e853ce


          change spaces to tabs

5743a01

christian-byrne mentioned this pull request

[Bug]: Newest frontend version breaks Thumbnail views Comfy-Org/ComfyUI_frontend#2252

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet