-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial improved click-to-copy for resources page #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create doc/_includes * Move links.rst there * Move the resource inclusion there using the include_file feature from the Vfs
* Add custom JS to the force-copy temp fix and clean up header * Add custom JS call to target ezcopy class * Add CSS for buttons * Very ugly code for generating the buttons
* Wrap the literal and button in a span * Add styling * Remove indent argument from function likely to be removed soon
* Use iterators instead of non-stop modulo and variable references * Simplify column detection: 1 column when n=1, 3 for fonts, 2 for all else * Add arguments to allow passing in the value to the table generation from outside
* fix missing variable name in create_resources_path * rename create_resources_path to path_as_resource_handle:
* s/quote(/html_quote(/g * use better resource paths * explain a few things better
* Start switching over config reading * Partly decruft the methods
* Use Python's standard library to handle HTML escaping * Remove custom html quote function * Add prefix of handle string as table caption with CSS to make it match the copyables more
* Fix heading generation and start improving the ordering for auto-generation * Fix the include ordering for the resources pages * Add site-wide |Copy Button substitution * Add rough instructions for the copy buttons based on feedback
* Remove code from .rst generation * Remove CSS supporting the .. raw:: html for unknown file types
* Styles almost correctly with hover (inline is breaking) * Add .doc-ui-example-dummy class intended to shut off UI behavior on dummy elements * CSS changes to support the UI elements and on-page instructions * Document some flaws better * Add |Example Copy Button| substitution for Sphinx embeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Click-to-copy buttons for every built-in asset + start of in-
.rst
file:resource:
embeds elsewhereWhy?
This makes it easier to answer the most common beginner questions:
Add Liberation font family to Arcade #2477
Make post-3.0 life easier
The code is less bad than it was
What?
Rough versions of things we will improve on in future PRs:
In-tile copy buttons:
Liberation font family preview
Various other fixes