Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlparse<0.2 #990

Merged
merged 2 commits into from
Aug 13, 2016
Merged

Conversation

Mariatta
Copy link
Member

added sqlparse<0.2 to requirements.txt to address #989

@berkerpeksag
Copy link
Member

Could you add a TODO comment and explain why we need to add this (something like "delete this when we switch to Django 1.8 and DDT 1.5")?

@@ -43,3 +43,4 @@ uWSGI==2.0.10

raven==5.2.0
django-waffle==0.11.1
sqlparse <0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: sqlparse <0.2 -> sqlparse<0.2

remove space before <
@Mariatta
Copy link
Member Author

Thanks for the feedback @berkerpeksag
Added todo comment and removed the space before < sign

@berkerpeksag berkerpeksag merged commit d5790b0 into python:master Aug 13, 2016
@berkerpeksag
Copy link
Member

Thanks!

@Mariatta Mariatta deleted the add-sqlparse-requirement branch August 14, 2016 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants