gh-69001: Convert links to more usable buttons #129591
Conversation
| info_buttons = Frame(frame_background, bg=self.bg) | ||
| info_buttons.grid(row=3, column=0, columnspan=1, sticky=NSEW) |
There was a problem hiding this comment.
I would rather delete info_buttons and derive the new buttons directly from frame_background (and change the grid lines to 6 and 7) as before. I want to be able to move them independently in another PR.
| forums.bind("<Button-1>", lambda event: webbrowser.open(forums_url)) | ||
| info_buttons = Frame(frame_background, bg=self.bg) | ||
| info_buttons.grid(row=3, column=0, columnspan=1, sticky=NSEW) | ||
| forums = Button(info_buttons, text='Python Discuss', width=35, |
There was a problem hiding this comment.
| forums = Button(info_buttons, text='Python Discuss', width=35, | |
| forums = Button(info_buttons, text='Python (and IDLE) Discussion', width=35, |
| justify=LEFT, fg=self.fg, bg=self.bg) | ||
| docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0) | ||
| docs.bind("<Button-1>", lambda event: webbrowser.open(docs_url)) | ||
| docs = Button(info_buttons, text='Python Documentation', width=35, |
There was a problem hiding this comment.
This URL is specifically for IDLE. This is redundant with the IDLE Docs entry in the HELP menu, but this PR is about button instead of label.
| docs = Button(info_buttons, text='Python Documentation', width=35, | |
| docs = Button(info_buttons, text='IDLE Documentation', width=35, |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Makes it a LOT clearer that they are buttons. (I opened about 15 tabs before I noticed on the current version)
Much better for accessibility as buttons are keyboard usable.