gh-126835: Move constant subscript folding to CFG #129568
Merged
+138
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolframAlph
requested review from
Eclips4,
isidentical,
markshannon and
iritkatriel
as code owners
iritkatriel
reviewed
Feb 2, 2025
iritkatriel
reviewed
Feb 2, 2025
tomasr8
reviewed
Feb 2, 2025
No, we can merge this first so you can make progress with the folding business. I'm still working on that one. |
iritkatriel
reviewed
Feb 2, 2025
iritkatriel
reviewed
Feb 2, 2025
Co-authored-by: Irit Katriel <[email protected]>
This was referenced Feb 3, 2025
Eclips4
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
LGTM. I'll wait until the test case is split (#129568 (comment)) and then merge it. However, I think it's worth adding a NEWS entry as all our PRs related to moving the folding optimization from ast to CFG will require it.
Moving folding from ast construction to codegen/flowgraph definitely needs a news entry because ast.parse() is in the stdlib. Moving a folding from codegen to flow graph is no that exposed to users, but we might as well mention it in the whatsnew in case behaviour changed in some edge case and someone will want to look up why it may be so. That said, one whatnew entry about all the folding moves will probably be enough (pointing to multiple issues if need be). |
Agreed. So let's do it when all the folding has been moved. |
|
I have split tests and added |
|
|
|
|
|
|
|
|
@WolframAlph @Eclips4: This change introduced a reference leak, see #129635. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Eclips4 @tomasr8