Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126018: Avoid aborting due to unnecessary assert in sys.audit #126020

Merged
merged 7 commits into from
Oct 27, 2024
Merged

gh-126018: Avoid aborting due to unnecessary assert in sys.audit #126020

merged 7 commits into from
Oct 27, 2024

Commits on Oct 26, 2024

  1. Remove an assert that sys.audit's args[0] passes PyUnicode_Check.

    @devdanzin
    devdanzin committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    ba8ac4d View commit details
    Browse the repository at this point in the history

  2. Test that passing a non-string to sys.audit doesn't trigger an assert… 

    … in debug builds.
    @devdanzin
    devdanzin committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    620f682 View commit details
    Browse the repository at this point in the history

  3. 📜🤖 Added by blurb_it.

    @blurb-it
    blurb-it[bot] authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    b775f5d View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Bénédikt Tran <[email protected]>
    @devdanzin @picnixz
    devdanzin and picnixz authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    6234c5d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Apply suggestions from code review by @Eclips4.

    @devdanzin
    devdanzin committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    a6edd2c View commit details
    Browse the repository at this point in the history

  2. Fail test_assert_unicode if no exception is raised by sys.audit(9) (t… 

    …hanks @JelleZijlstra).
    @devdanzin
    devdanzin committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    57cc87c View commit details
    Browse the repository at this point in the history

  3. Apply review suggestion for better description of issue in NEWS. 

    Co-authored-by: Jelle Zijlstra <[email protected]>
    @devdanzin @JelleZijlstra
    devdanzin and JelleZijlstra authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    c42c4d6 View commit details
    Browse the repository at this point in the history