-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-75459: Doc: C API: Improve object life cycle documentation #125962
Open
rhansen
wants to merge
5
commits into
python:main
Choose a base branch
from
rhansen:docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+565
−44
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bc32398
gh-75459: Doc: C API: Improve object life cycle documentation
rhansen 361eaca
gh-75459: Doc: Tell sphinx to run graphviz
rhansen b27bcca
add blurb
rhansen b42b58d
Revert "gh-75459: Doc: Tell sphinx to run graphviz"
rhansen 7e571ae
delete "ref count == 0" node, link directly to `tp_dealloc`
rhansen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
digraph G { | ||
graph [ | ||
fontname="svg" | ||
fontsize=10.0 | ||
layout="dot" | ||
ranksep=0.25 | ||
] | ||
node [ | ||
fontname="Courier" | ||
fontsize=10.0 | ||
] | ||
edge [ | ||
fontname="Times-Italic" | ||
fontsize=10.0 | ||
] | ||
|
||
"start" [fontname="Times-Italic" shape=plain label=< start > style=invis] | ||
"tp_alloc" [href="typeobj.html#c.PyTypeObject.tp_alloc" target="_top"] | ||
"tp_new" [href="typeobj.html#c.PyTypeObject.tp_new" target="_top"] | ||
"tp_init" [href="typeobj.html#c.PyTypeObject.tp_init" target="_top"] | ||
{ | ||
rank="same" | ||
"alive" [ | ||
fontname="Times-Italic" | ||
label=<alive, ref count > 0> | ||
shape=box | ||
] | ||
"tp_traverse" [ | ||
href="typeobj.html#c.PyTypeObject.tp_traverse" | ||
shape=octagon | ||
target="_top" | ||
] | ||
} | ||
"tp_finalize" [ | ||
href="typeobj.html#c.PyTypeObject.tp_finalize" | ||
shape=octagon | ||
target="_top" | ||
] | ||
"tp_clear" [ | ||
href="typeobj.html#c.PyTypeObject.tp_clear" | ||
shape=octagon | ||
target="_top" | ||
] | ||
"tp_dealloc" [ | ||
href="typeobj.html#c.PyTypeObject.tp_dealloc" | ||
ordering="in" | ||
target="_top" | ||
] | ||
"tp_free" [href="typeobj.html#c.PyTypeObject.tp_free" target="_top"] | ||
|
||
"start" -> "tp_alloc" | ||
"tp_alloc" -> "tp_new" | ||
"tp_new" -> "tp_init" | ||
"tp_init" -> "alive" | ||
"tp_traverse" -> "alive" | ||
"alive" -> "tp_traverse" | ||
"alive" -> "tp_clear" [label=< cyclic <br/>isolate >] | ||
"alive" -> "tp_finalize" [ | ||
dir="back" | ||
label=< resurrected > | ||
] | ||
"alive" -> "tp_finalize" [label=< cyclic <br/>isolate >] | ||
"tp_finalize" -> "tp_clear" | ||
"tp_finalize" -> "tp_dealloc" [ | ||
dir="back" | ||
href="lifecycle.html#c.PyObject_CallFinalizerFromDealloc" | ||
label=< | ||
<table border="0" cellborder="0" cellpadding="0" cellspacing="0"> | ||
<tr> | ||
<td rowspan="4"> </td> | ||
<td align="left">optional call to</td> | ||
<td rowspan="4"> </td> | ||
</tr> | ||
<tr> | ||
<td align="left"><font face="Courier">PyObject_Call</font></td> | ||
</tr> | ||
<tr> | ||
<td align="left"><font face="Courier">FinalizerFrom</font></td> | ||
</tr> | ||
<tr><td align="left"><font face="Courier">Dealloc</font></td></tr> | ||
</table> | ||
> | ||
target="_top" | ||
] | ||
"tp_finalize" -> "tp_dealloc" [label=< ref count <br/> == 0 >] | ||
"tp_clear" -> "tp_dealloc" [label=< ref count <br/> == 0 >] | ||
"tp_clear" -> "tp_dealloc" [ | ||
dir="back" | ||
label=< optional<br/>direct call > | ||
] | ||
"alive" -> "tp_dealloc" [label=< ref count <br/> == 0 >] | ||
"tp_dealloc" -> "tp_free" [label=< directly calls >] | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the original sentence did a better job at explaining what the macro does, whereas the new one focuses more on the "how".
Perhaps this is better?