-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125927: Add docs description for daemon thread #125961
base: main
Are you sure you want to change the base?
Conversation
I think this looks fine, but I'm assuming that Eric wanted something a bit more in depth judging by the original issue, so I'm going to refrain from approving for now. |
Actually, the focus is on highlighting the differences between Python threads and other threads. This clearly illustrates the unique aspects of Python daemon threads, and I believe Eric won’t have any objections to this. |
Well, IIUC, part the motivation was to document some of the concerns about daemon threads as well. This sort of tells you what to do with them, but not what's wrong with them. |
So in the description, I described that join should be used to solve it. |
That's not that useful though, because the whole point of a daemon thread is that you don't want it to join. |
📚 Documentation preview 📚: https://cpython-previews--125961.org.readthedocs.build/