-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-87063: Add closed
attribute to multiprocessing.Process
#125838
base: main
Are you sure you want to change the base?
Conversation
It seems that this NEWS error can be ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More generally, required CI checks must never be ignored except for NEWS missing / issue missing since normal users cannot apply the skip news/issue labels themselves.
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
closed
attribute to multiprocessing.Process
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR author did not listen to feedback. Requesting changes to make this point clearer.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry for my misunderstanding. I thought it was to change NEWS to what's NEWS, but it was actually to add to it. I'm sorry for that. I've made change :) |
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
Thanks to Bénédikt for taking responsibility for this PR. And, thanks to erlend for pointing out my mistake.👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A final nitpick. Concerning the naming of the attribute, I suggested a property + closed
but if @gpshead feels that it should be a method + is_closed()
, then I'm sorry in advance :) (just recalling that my rationale was that multiprocessing.connection.Connection
uses the closed
property but I don't know if properties are preferred over true methods when we are just returning a private attribute).
Misc/NEWS.d/next/Library/2024-10-22-19-52-15.gh-issue-87063.fR-wJa.rst
Outdated
Show resolved
Hide resolved
I've made change. Thank for your review! |
for example: