GH-125521: Remove if (true) from generated output to reduce C compiler warnings
#125700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
changed the title
if (true) from generated output to reduce C compiler warnings
iritkatriel
reviewed
Oct 21, 2024
| assert lparen.kind == "LPAREN" | ||
| first_tkn = tkn_iter.peek() | ||
| emit_to(self.out, tkn_iter, "COMMA") |
There was a problem hiding this comment.
Wouldn't it be simpler to just add an unconditional ERROR() macro to the DSL?
There was a problem hiding this comment.
That wouldn't prevent anyone writing ERROR_IF(true, ...) so we'd still need to handle it.
iritkatriel
approved these changes
Oct 21, 2024
|
Seems like there is no test for this. |
iritkatriel
reviewed
Oct 21, 2024
iritkatriel
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aarch64-unknown-linux-gnu/gcc (Debug)#125521