Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125625: Enable 3.13 py.exe can be use on PCBuild #125626

Merged
merged 1 commit into from
Oct 17, 2024
Merged

gh-125625: Enable 3.13 py.exe can be use on PCBuild #125626

merged 1 commit into from
Oct 17, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Oct 16, 2024 •
edited
Loading

@Wulian233 Wulian233 requested a review from a team as a code owner October 16, 2024 22:42
@bedevere-app bedevere-app bot mentioned this pull request Oct 16, 2024
Closed
vstinner
vstinner approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware zware merged commit 0cb20f2 into python:main Oct 17, 2024
38 checks passed
@zware zware added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Oct 17, 2024
@miss-islington-app
Copy link

Thanks @Wulian233 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @Wulian233 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2024
@Wulian233 @miss-islington
pythongh-125625: Check for py -3.13 in PCbuild/find_python.bat (pyt…
d141ae7 
…honGH-125626)

(cherry picked from commit 0cb20f2)

Co-authored-by: Wulian <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2024
@Wulian233 @miss-islington
pythongh-125625: Check for py -3.13 in PCbuild/find_python.bat (pyt…
6b8d4d3 
…honGH-125626)

(cherry picked from commit 0cb20f2)

Co-authored-by: Wulian <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 17, 2024

GH-125649 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 17, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 17, 2024

GH-125650 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 17, 2024
@Wulian233 Wulian233 deleted the pcbuild313 branch October 17, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@rruuaanng rruuaanng rruuaanng approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wulian233 @vstinner @rruuaanng @zware