Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check #125612

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check #125612

wants to merge 2 commits into from
+4 −1

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Oct 16, 2024 •
edited by bedevere-app bot
Loading

The STORE_ATTR_INSTANCE_VALUE opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.

@colesbury
pythongh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check
3a126a8 
The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with
non-NULL managed dictionaries, so don't specialize to that op in that case.
@bedevere-app bedevere-app bot mentioned this pull request Oct 16, 2024
Open
@colesbury colesbury marked this pull request as ready for review October 17, 2024 14:12
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Oct 17, 2024
markshannon
markshannon reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should save a few repeated deopts.

I've one suggestion

Python/specialize.c Outdated Show resolved Hide resolved
@markshannon
Copy link
Member

markshannon commented Oct 24, 2024 •
edited
Loading

The stats show the expected reduction in misses for STORE_ATTR_INSTANCE_VALUE

@colesbury @markshannon
Update Python/specialize.c
9aa12bd 
Co-authored-by: Mark Shannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
awaiting core review needs backport to 3.13 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @markshannon