gh-125500: threading.py Timer context manager #125501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for context manager. Start on entry, cancel on exit
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
graingert
reviewed
Oct 15, 2024
| self.start() | ||
|
|
||
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| self.cancel() |
There was a problem hiding this comment.
this should probably join the Timer thread
There was a problem hiding this comment.
Why block the main thread for a canceled timer?
There was a problem hiding this comment.
The main thread won't be blocked very long, it's to support use cases like:
with Timer(1, print, ("Trust me, I'm on it...",)):
time.sleep(2)
os.fork() # all threads need to be joined before calling fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for context manager. Start on entry, cancel on exit