Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) #125466

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) #125466

merged 3 commits into from
Oct 17, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 14, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 14, 2024
Closed
@graingert graingert changed the title gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) [3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959) Oct 14, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 14, 2024
Merged
@graingert graingert closed this Oct 14, 2024
@graingert graingert reopened this Oct 14, 2024
@graingert graingert marked this pull request as ready for review October 14, 2024 15:45
@1st1
Copy link
Member

1st1 commented Oct 15, 2024

What's this DO NOT MERGE label business?

@graingert
Copy link
Contributor Author

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

@1st1 1st1 merged commit 32d4579 into python:3.12 Oct 17, 2024
28 checks passed
@graingert graingert deleted the backport-d5dbbf4-3.12 branch October 17, 2024 07:44
@gvanrossum
Copy link
Member

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

Sure, but please understand not everyone is aware of the reasons, so next time please add a comment to explain. (Also my pet peeve for revert PRs, too few people don’t say why it is being reverted and the OP has to hunt for the reason.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graingert @1st1 @gvanrossum @kumaraditya303