Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-125449: Remove PyUnicode_READY function in unicodeobject.h #125450

Closed
wants to merge 2 commits into from

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Oct 14, 2024

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this function.

A code search on PyUnicode_READY in PyPI top 7,500 projects found 133 matching lines in 43 projects.

cc @methane

@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@rruuaanng
Copy link
Contributor Author

Please keep this function.

A code search on PyUnicode_READY in PyPI top 7,500 projects found 133 matching lines in 43 projects.

cc @methane

If so, maybe I should close this PR.

@rruuaanng rruuaanng closed this Oct 14, 2024
@rruuaanng rruuaanng deleted the gh125449 branch October 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants