gh-125041: test_zlib: For s390x HW acceleration, only skip checking the compressed bytes #125042
Conversation
encukou
commented
Oct 7, 2024
•
encukou
commented
- Issue: Re-enable skipped test_zlib tests on s390x hardware acceleration #125041
…king the compressed bytes
| @@ -0,0 +1,3 @@ | |||
| Re-enable skipped tests for :mod:`zlib` on the s390x architecture: only skip | |||
There was a problem hiding this comment.
It seems that NEWS isn't required for unittest.
There was a problem hiding this comment.
Right, it's not required.
|
s390x buildbots were removed, so there's no way for me to test this right now :( |
|
!buildbot s390x |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 126109b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
LGTM. I just left minor coding style remarks.
I don't recall exactly the details, I skipped these tests 2 years ago. But from what I read, the change looks correct.
Sadly, I don't recall how to reproduce the issue: how to get access to a s390x machine where the hardware acceleration is enabled.
Lib/test/test_zlib.py
Outdated
| self.assertEqual(zlib.compress(bytearray(data)), x) | ||
| if not HW_ACCELERATED: | ||
| # With hardware acceleration, the compressed bytes | ||
| # might not be identical. |
There was a problem hiding this comment.
nitpick: can you put the comment on the if instead? same comment below.
|
The new builders have HW acceleration -- the tests fail on |
|
Sorry, not |
encukou
added
needs backport to 3.11
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @encukou, I could not cleanly backport this to |
…king the compressed bytes (pythonGH-125042) (cherry picked from commit cc5a225) Co-authored-by: Petr Viktorin <[email protected]>
…king the compressed bytes (pythonGH-125042) (cherry picked from commit cc5a225) Co-authored-by: Petr Viktorin <[email protected]>
|
GH-125526 is a backport of this pull request to the 3.12 branch. |
|
GH-125527 is a backport of this pull request to the 3.13 branch. |
…cking the compressed bytes (GH-125042) (#125527) (cherry picked from commit cc5a225) Co-authored-by: Petr Viktorin <[email protected]>
…king the compressed bytes (python#125042) (cherry picked from commit cc5a225)
|
GH-125577 is a backport of this pull request to the 3.11 branch. |
…, skip checking the compressed bytes (pythonGH-125042) This backports two commits: - pythonGH-31096 skipped the tests unconditionally - pythonGH-125042 skips only the possibly-failing assertion (cherry picked from commit cc5a225)
|
GH-125585 is a backport of this pull request to the 3.10 branch. |
…ration, skip checking the compressed bytes (pythonGH-125042) This backports two commits: - pythonGH-31096 skipped the tests unconditionally - pythonGH-125042 skips only the possibly-failing assertion (cherry picked from commit d522856) Co-authored-by: Petr Viktorin <[email protected]>
|
GH-125587 is a backport of this pull request to the 3.9 branch. |
…cking the compressed bytes (GH-125042) (GH-125526) (cherry picked from commit cc5a225) Co-authored-by: Petr Viktorin <[email protected]>
…p checking the compressed bytes (GH-125042) (#125585) gh-125041: gh-90781: test_zlib: For s390x HW acceleration, skip checking the compressed bytes (GH-125042) This backports two commits: - GH-31096 skipped the tests unconditionally - GH-125042 skips only the possibly-failing assertion (cherry picked from commit cc5a225)
