gh-121404: more compiler_* -> codegen_*, class_body and comprehensions #123262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Aug 23, 2024
•
iritkatriel
commented
- Issue: split compiler.c into compiler and codegen #121404
picnixz
changed the title
picnixz
reviewed
Aug 23, 2024
Co-authored-by: Bénédikt Tran <[email protected]>
markshannon
reviewed
Aug 23, 2024
| @@ -96,6 +96,7 @@ static PySTEntryObject *compiler_symtable_entry(struct compiler *c); | |||
| #define IS_INTERACTIVE(C) compiler_is_interactive(C) | |||
| #define IS_NESTED_SCOPE(C) compiler_is_nested_scope(C) | |||
| #define SCOPE_TYPE(C) compiler_scope_type(C) | |||
| #define QUALNAME(C) compiler_qualname(C) | |||
There was a problem hiding this comment.
I see why you are adding this macro; it fits the pattern.
But OOI, why do we have all these macros in the first place?
There was a problem hiding this comment.
I don't know why originally, but I think it will be handy for customizing the compiler after I finish the split. We'll see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.