Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123243: Fix reference leak in _decimal #123244

Merged
merged 8 commits into from
Aug 24, 2024
Merged

gh-123243: Fix reference leak in _decimal #123244

merged 8 commits into from
Aug 24, 2024

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Aug 22, 2024 •
edited by bedevere-app bot
Loading 

>python -X showrefcount -c "import _decimal"
[7117 refs, 4232 blocks]   # Before
[0 refs, 0 blocks]         # After

cc @kumaraditya303 @erlend-aasland

@bedevere-app bedevere-app bot mentioned this pull request Aug 22, 2024
Closed
@rhettinger rhettinger removed their request for review August 23, 2024 00:12
@kumaraditya303 kumaraditya303 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 23, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 33af89b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 23, 2024
@kumaraditya303 kumaraditya303 merged commit 5ff638f into python:main Aug 24, 2024
50 of 51 checks passed
@kumaraditya303 kumaraditya303 added the needs backport to 3.13 bugs and security fixes label Aug 24, 2024
@miss-islington-app
Copy link

Thanks @neonene for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 24, 2024
@neonene @miss-islington
pythongh-123243: Fix reference leak in _decimal (pythonGH-123244)
ddc48bf 
(cherry picked from commit 5ff638f)

Co-authored-by: neonene <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 24, 2024

GH-123280 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 24, 2024
kumaraditya303 pushed a commit that referenced this pull request Aug 24, 2024
@miss-islington @neonene
[3.13] gh-123243: Fix reference leak in _decimal (GH-123244) (#123280)
a65fe07 
gh-123243: Fix reference leak in `_decimal` (GH-123244)
(cherry picked from commit 5ff638f)

Co-authored-by: neonene <[email protected]>
@neonene neonene deleted the decimal-leak branch August 24, 2024 08:25
@ZeroIntensity ZeroIntensity mentioned this pull request Sep 4, 2024
Closed
@ZeroIntensity
Copy link
Member

This has caused a regression: #123657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neonene @bedevere-bot @ZeroIntensity @erlend-aasland @kumaraditya303