gh-122905: Sanitize names in zipfile.Path. #122906
Conversation
Closes python#122905; Ported from zipp 3.19.1; ref jaraco/zipp#119.
jaraco
added
needs backport to 3.8
needs backport to 3.9
|
This behavior has been published in jaraco/zipp since 2024-05-31, so I'm confident it's stable. |
|
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. |
Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) Co-authored-by: Jason R. Coombs <[email protected]>
|
GH-122922 is a backport of this pull request to the 3.13 branch. |
Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) Co-authored-by: Jason R. Coombs <[email protected]>
|
GH-122923 is a backport of this pull request to the 3.12 branch. |
|
Sorry, @jaraco, I could not cleanly backport this to |
|
Sorry, @jaraco, I could not cleanly backport this to |
|
Sorry, @jaraco, I could not cleanly backport this to |
|
Sorry, @jaraco, I could not cleanly backport this to |
Ported from zipp 3.19.1; ref jaraco/zipp#119. (cherry picked from commit 9cd0326)
) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) Co-authored-by: Jason R. Coombs <[email protected]>
|
GH-122925 is a backport of this pull request to the 3.11 branch. |
|
I've proposed the backport to 3.11. I'm hoping to cherrypick that to 3.10 and earlier, assuming it's accepted, rather that cherry-picking the change in main and re-reconciling the conflicts. |
* gh-122905: Sanitize names in zipfile.Path. (#122906) Ported from zipp 3.19.1; ref jaraco/zipp#119. (cherry picked from commit 9cd0326) * [3.11] gh-122905: Sanitize names in zipfile.Path. (GH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) Co-authored-by: Jason R. Coombs <[email protected]>
…nGH-122906) (pythonGH-122925) * pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) * [3.11] pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) (cherry picked from commit 795f259) Co-authored-by: Jason R. Coombs <[email protected]>
…GH-122906) (pythonGH-122925) * pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) * [3.11] pythongh-122905: Sanitize names in zipfile.Path. (pythonGH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) (cherry picked from commit 795f259) Co-authored-by: Jason R. Coombs <[email protected]>
|
GH-123161 is a backport of this pull request to the 3.9 branch. |
|
GH-123162 is a backport of this pull request to the 3.8 branch. |
|
GH-123160 is a backport of this pull request to the 3.10 branch. |
Ported from zipp 3.19.1; ref jaraco/zipp#119.
|
That's weird - all three backports (3.8, 3.9, 3.10) are failing on the macos runners, two of them with segmentation faults. I'm 99.9% certain these changes aren't directly implicated. I've restarted the runners to see if maybe that clears things up, but there seems to be some stability issues on those branches. |
[3.10] [3.11] gh-122905: Sanitize names in zipfile.Path. (GH-122906) (GH-122925) * gh-122905: Sanitize names in zipfile.Path. (GH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) * [3.11] gh-122905: Sanitize names in zipfile.Path. (GH-122906) Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326) (cherry picked from commit 795f259)
|
This introduced a regression: #123270. |
Closes #122905; Ported from zipp 3.19.1; ref jaraco/zipp#119.