gh-119771: adjust errno on overflows in _Py_c_pow() #120256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we did this in complex_pow() and behaviour of the public C API function ``_Py_c_pow()`` was different from the pure-python pow().
vstinner
reviewed
Jun 8, 2024
Co-authored-by: Victor Stinner <[email protected]>
skirpichev
commented
Jun 8, 2024
| @@ -546,12 +548,12 @@ complex_pow(PyObject *v, PyObject *w, PyObject *z) | |||
| // a faster and more accurate algorithm. | |||
| if (b.imag == 0.0 && b.real == floor(b.real) && fabs(b.real) <= 100.0) { | |||
| p = c_powi(a, (long)b.real); | |||
| _Py_ADJUST_ERANGE2(p.real, p.imag); | |||
There was a problem hiding this comment.
That might be moved to c_powi(), but that will make patch slightly larger. I think this is fine, as c_powi() is not a part of C API.
|
@vstinner, do you want a second opinion on this? |
|
Merged, thanks. I made minor edits on the commit message. |
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
Before we did this in complex_pow() and behavior of the public C API function _Py_c_pow() was different from the pure-python pow().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we did this in complex_pow() and behaviour of the public C API function
_Py_c_pow()was different from the pure-python pow().📚 Documentation preview 📚: https://cpython-previews--120256.org.readthedocs.build/