-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-115775: Use __static_attributes__
to initialize shared keys
#118468
GH-115775: Use __static_attributes__
to initialize shared keys
#118468
Conversation
markshannon
commented
May 1, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Use static analysis to assist inlining values and compact object layout. #115775
No need for news item as it is covered by #117909 |
dedffa7
to
5032ad9
Compare
846a7ef
to
a7b858b
Compare
b64de3d
to
d54afaf
Compare
The stats are not obviously better. This PR reduces misses in Both From this, it appears that this PR does what it aims to do. It also appears that it would be worth improving our handling of shadowed attributes. I plan to fix the shadowing issue before merging this, so that it becomes a clear improvement |
Now that #123040 is fixed things look much better. Performance shows no change apart from the "go" benchmark speeds up by 35%. The "go" benchmark creates many objects before initializing them, which is a pattern that this PR allows us to optimize. The stats show a small increase in specialization of |