gh-116560: Add PyLong_GetSign() public function #116561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename _PyLong_Sign() to PyLong_Sign() * add argument checking, documentation and tests * keep _PyLong_Sign() as an alias to PyLong_Sign()
Eclips4
reviewed
Mar 10, 2024
Misc/NEWS.d/next/C API/2024-03-10-14-55-51.gh-issue-116560.x2mZaO.rst
Outdated
Show resolved
Hide resolved
vstinner
reviewed
Mar 11, 2024
vstinner
reviewed
Mar 11, 2024
|
I created capi-workgroup/decisions#19 for this API. |
The SC decided to adopt this API: capi-workgroup/decisions#19 (comment) @skirpichev: Would you mind to update your PR for this API? |
|
@vstinner, I think it's already in sync with that version. Sphinx docs use slightly different wording. Let me know if you prefer variant from capi-workgroup/decisions#19 (comment). |
vstinner
reviewed
Jun 2, 2024
Well, the C API WG prefers the name |
vstinner
reviewed
Jun 2, 2024
Co-authored-by: Victor Stinner <[email protected]>
vstinner
changed the title
vstinner
reviewed
Jun 2, 2024
Co-authored-by: Victor Stinner <[email protected]>
vstinner
approved these changes
Jun 3, 2024
skirpichev
commented
Jun 3, 2024
Co-authored-by: Sergey B Kirpichev <[email protected]>
|
Thanks for review and patience:) |
auto-merge was automatically disabled
June 3, 2024 07:55
Head branch was pushed to by a user without write access
devdanzin
reviewed
Jun 3, 2024
skirpichev
commented
Jun 3, 2024
|
Merged, thanks. |
|
Function added to pythoncapi-compat: python/pythoncapi-compat@18d1df7 |
mliezun
pushed a commit
to mliezun/cpython
that referenced
this pull request
Jun 3, 2024
Co-authored-by: Victor Stinner <[email protected]>
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Victor Stinner <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Co-authored-by: Victor Stinner <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyLong_Sign()now is a wrapper to_PyLong_Sign(): argument checking added, also documentation and testsNotes: Some
PyLong_As*functions fallback to__index__()call, some not. C.f.PyLong_AsLong()vsPyLong_AsSsize_t(). Not sure if this is not a bug, but second was chosen.📚 Documentation preview 📚: https://cpython-previews--116561.org.readthedocs.build/