Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111933: fix broken link to A.Neumaier article #111937

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Nov 10, 2023

It seems there are links to the archive.org in comments across the codebase. So, I hope it's fine.

Alternatively, we could point to the journal page: https://doi.org/10.1002/zamm.19740540106 (not open access, however). Or just add a citation (Neumaier, A. (1974), Rundungsfehleranalyse einiger Verfahren zur Summation endlicher Summen. Z. angew. Math. Mech., 54: 39-51.).

@skirpichev
Copy link
Member Author

CC @rhettinger

@JelleZijlstra
Copy link
Member

I would prefer adding the DOI and the full citation to the comment. It's better to have more ways to find the article for those interested.

Python/bltinmodule.c Outdated Show resolved Hide resolved
@skirpichev
Copy link
Member Author

I've commited @JelleZijlstra suggestion above, but archive.org link was replaces with url to the prof.Neumaier homepage (https://arnold-neumaier.at/scan/01.pdf), thanks to @pochmann.

@rhettinger rhettinger added the 3.12 bugs and security fixes label Nov 11, 2023
@terryjreedy
Copy link
Member

How about adding 'https://en.wikipedia.org/wiki/2Sum'? For me, it is a more useful link than the noisy image of German text, which as an image cannot be put into a translator.

@skirpichev
Copy link
Member Author

How about adding 'https://en.wikipedia.org/wiki/2Sum'?

Then, maybe
https://en.wikipedia.org/wiki/Kahan_summation_algorithm#Further_enhancements
? It has relevant pseudocode and also a link (broken) to scanned text.

@hugovk hugovk added the needs backport to 3.12 bug and security fixes label Nov 11, 2023
Python/bltinmodule.c Outdated Show resolved Hide resolved
@rhettinger rhettinger merged commit 12a30bc into python:main Nov 12, 2023
28 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2023
(cherry picked from commit 12a30bc)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2023

GH-111993 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 12, 2023
@skirpichev skirpichev deleted the fix-sum-link branch November 12, 2023 02:20
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants