-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-78469: Declare missing sethostname for Solaris 10 #109447
Changes from 2 commits
e71d8fb
5593f21
bc5523e
3a96e29
691441c
f8f49e4
5970802
9cb0a31
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -590,6 +590,14 @@ then | |
darwin*) MACHDEP="darwin";; | ||
'') MACHDEP="unknown";; | ||
esac | ||
|
||
if test "$ac_sys_system" = "SunOS"; then | ||
# For Solaris, there isn't an OS version specific macro defined | ||
# in most compilers, so we define one here. | ||
SUNOS_VERSION=`echo $ac_sys_release | tr -d '.'` | ||
kulikjak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
AC_DEFINE_UNQUOTED([SUNOS_VERSION], [$SUNOS_VERSION], | ||
[The version of SunOS/Solaris as reported by `uname -r' without the dot.]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How do you distinguish Solaris 5.10 and Solaris 51.0? Maybe multiply the major version by 100 or 1000? or use a shift of 8 bits? The usage would be:
The disavantage is the need to write versions in hexadecimal :-( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @erlend-aasland: Should we prefix new pyconfig.h constants by Py_ ? see: capi-workgroup/problems#46 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should follow the PEP-7 recommendations: https://peps.python.org/pep-0007/#naming-conventions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I see what you mean, but that's not happening. The leading 5 was dropped from the name 25 years ago and while e.g. That said, I am not strongly against changing it if you still prefer your suggestion.
Thanks, I missed that. It's fixed now. |
||
fi | ||
fi | ||
AC_MSG_RESULT(["$MACHDEP"]) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, that's very spefic. It was available before and after, but not at version 510? :-)