Use ValueError instead of RuntimeError

python · Oct 18, 2024 · d16cfad · d16cfad
1 parent c8a8eb4
commit d16cfad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Lib/test/test_frame.py b/Lib/test/test_frame.py
@@ -405,16 +405,16 @@ def test_delete(self):
         with self.assertRaises(KeyError):
             d.pop('non_exist')
 
-        with self.assertRaisesRegex(RuntimeError, 'local variables'):
+        with self.assertRaisesRegex(ValueError, 'local variables'):
             del d['x']
 
         with self.assertRaises(AttributeError):
             d.clear()
 
-        with self.assertRaises(RuntimeError):
+        with self.assertRaises(ValueError):
             d.pop('x')
 
-        with self.assertRaises(RuntimeError):
+        with self.assertRaises(ValueError):
             d.pop('x', None)
 
         # 'm', 'n' is stored in f_extra_locals

diff --git a/Objects/frameobject.c b/Objects/frameobject.c
@@ -165,7 +165,7 @@ framelocalsproxy_setitem(PyObject *self, PyObject *key, PyObject *value)
     }
     if (i >= 0) {
         if (value == NULL) {
-            PyErr_SetString(PyExc_RuntimeError, "cannot remove local variables from FrameLocalsProxy");
+            PyErr_SetString(PyExc_ValueError, "cannot remove local variables from FrameLocalsProxy");
             return -1;
         }
 
@@ -707,7 +707,7 @@ framelocalsproxy_pop(PyObject* self, PyObject *const *args, Py_ssize_t nargs)
     }
 
     if (i >= 0) {
-        PyErr_SetString(PyExc_RuntimeError, "cannot remove local variables from FrameLocalsProxy");
+        PyErr_SetString(PyExc_ValueError, "cannot remove local variables from FrameLocalsProxy");
         return NULL;
     }