Skip to content

Commit

Permalink
gh-100141: Allow pdb to deal with empty file (#125425)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaogaotiantian authored Oct 15, 2024
1 parent c6e8ff8 commit bb9604b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
3 changes: 1 addition & 2 deletions Lib/pdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,7 @@ def user_call(self, frame, argument_list):
def user_line(self, frame):
"""This function is called when we stop or break at this line."""
if self._wait_for_mainpyfile:
if (self.mainpyfile != self.canonic(frame.f_code.co_filename)
or frame.f_lineno <= 0):
if (self.mainpyfile != self.canonic(frame.f_code.co_filename)):
return
self._wait_for_mainpyfile = False
self.bp_commands(frame)
Expand Down
10 changes: 10 additions & 0 deletions Lib/test/test_pdb.py
Original file line number Diff line number Diff line change
Expand Up @@ -3999,6 +3999,16 @@ def _create_fake_frozen_module():
# verify that pdb found the source of the "frozen" function
self.assertIn('x = "Sentinel string for gh-93696"', stdout, "Sentinel statement not found")

def test_empty_file(self):
script = ''
commands = 'q\n'
# We check that pdb stopped at line 0, but anything reasonable
# is acceptable here, as long as it does not halt
stdout, _ = self.run_pdb_script(script, commands)
self.assertIn('main.py(0)', stdout)
stdout, _ = self.run_pdb_module(script, commands)
self.assertIn('__main__.py(0)', stdout)

def test_non_utf8_encoding(self):
script_dir = os.path.join(os.path.dirname(__file__), 'encoded_modules')
for filename in os.listdir(script_dir):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed the bug where :mod:`pdb` will be stuck in an infinite loop when debugging an empty file.

0 comments on commit bb9604b

Please sign in to comment.