feat(#14): import gitlab stuff #18
Conversation
There was a problem hiding this comment.
Will need Gitlab publishing. Unsure how atm (never used gitlab)
Could maybe base off of https://github.com/docker/build-push-action/blob/4f58ea79222b3b9dc2c8bbdd6debcef730109a75/.github/workflows/.e2e-run.yml, https://github.com/docker/build-push-action/blob/4f58ea79222b3b9dc2c8bbdd6debcef730109a75/.github/workflows/e2e.yml#L43
There was a problem hiding this comment.
Yeah, we will need it, but maybe through manual dispatch? Let's discuss this separately.
There was a problem hiding this comment.
FWIW the docs on GL container registry are here: https://docs.gitlab.com/ee/user/packages/container_registry/index.html
I don't know how you'd upload images built on GitHub to this though.
.github/workflows/ci-images.yml
Outdated
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| # - uses: actions/checkout@v4 # I dont think this is needed given git context defaults in build-push-action? |
| # Using the image | ||
|
|
||
| We are publishing this Docker image on | ||
| [GitLab](https://gitlab.com/python-devs/ci-images/container_registry). |
There was a problem hiding this comment.
this and below needs update for GH
|
changing |
| jobs: | ||
| env: | ||
| GITHUB_REGISTRY: ghcr.io | ||
| GITLAB_REGISTRY: ${{ secrets.GITLAB_REGISTRY }} |
|
cc @warsaw |
| docker run ${{ env.GITHUB_REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-test mypy --version | ||
| docker run ${{ env.GITHUB_REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-test pipx --version | ||
|
|
||
| release: |
There was a problem hiding this comment.
Oh let's separate the publish process from now on.
Just verify and test will be enough.
|
|
||
| jobs: | ||
| env: | ||
| GITHUB_REGISTRY: ghcr.io |
There was a problem hiding this comment.
Please take a look at how we verify autoconf file at Github Action.
I wish to use similar approach at CI level.
https://github.com/python/cpython-devcontainers/blob/main/.github/workflows/ci.yml
|
I don't mind helping out with container stuff since I maintain it for mailman anyway. |
Moves Gitlab files here
Partially resolves #14