fixup async/await example after module rename #168 #213

[shuckc]

I noticed that the 'async/await example' in README no longer worked after the changes discussed in #168 were made in #213.
The module rename should be straightforward. However I also found that the return value of await r.read() was b'' ie. no longer included the data received in the first exchange, which was a bit concerning. I changed the example to just read the data property, which works at least for small responses.

Perhaps awaiting read() is still required - and it is a bug that the prior data is not included in the return value, but I am not sure enough to open that as an issue.

[codecov]

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          22       22           
  Lines        3204     3204           
=======================================
  Hits         3166     3166           
  Misses         38       38           

[pquentin]

Thanks! The behavior you're seeing is expected and the same as what urllib3 does: without preload_content=False, the response is already read, so reading more data returns "".

Your change is correct, merging.

[pquentin]

Would you be interested in helping us improving hip? We need, among other things, to migrate tests from sync to async, which is a great way to start. If you're interested, I can give more detailed instruction. :)

[shuckc]

Possibly - I'll keep working through the code and issue tracker to follow along. I joined the chat, and have followed trio for over a year or so. Other than rolling HTTP Basic auth and json= equivalents seems to work well so far.

[pquentin]

Do you mean that HTTP Basic Auth and json= are missing but the rest is working well so far? Are you using hip with Trio?