-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new backend for LinkedIn OpenID Connect #833
Add new backend for LinkedIn OpenID Connect #833
Conversation
… (not basic auth)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
==========================================
- Coverage 77.11% 77.09% -0.03%
==========================================
Files 337 337
Lines 10262 10276 +14
Branches 690 692 +2
==========================================
+ Hits 7914 7922 +8
- Misses 2192 2198 +6
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@nijel sorry I missed your initial comment, resolved your feedback. anything else keeping us from adding this pull request? |
Can you please also add tests for this? |
...and documentation to https://github.com/python-social-auth/social-docs |
haha, sure. i'll look into it :) |
tests should be ready, i'm preparing the docs as another pull request and will link it here, once i'm ready. |
Merged, thanks for your contribution! Please followup with the documentation PR. |
Proposed changes
LinkedIn OAuth2 has been deprecated as of August 2023 and been replace with OpenID connect.
This pull request adds LinkedIn OpenID Connect. It has a few specific adjustments as LinkedIn does not send any "nonce" and therefore does not work with the regular OpenID Connect implementation.
Thanks to #829 for the idea and the hint on the OpenID Connect auth base class.
Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.