New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Shortcuts can silently collide and overwrite end-points. #616

Open

selobu wants to merge 1 commit into python-restx:master from selobu:patch-1

selobu commented Aug 19, 2024

Shortcuts can silently collide and overwrite end-points, generating incorrect swagger documentation.

The following example is incorrectly generating the swagger document:

If you press the first get method all the methods having the same doc will expand at the same time:

It should raise a ValidationError with the proposed fixed as follows:


          fix 🐛 Shortcuts can silently collide and overwrite end-points, genera…

25955cc

…ting incorrect swagger documentation. namespace.py

Shortcuts can silently collide and overwrite end-points, generating incorrect swagger documentation.

The following example is incorrectly generating the swagger document:

![image](https://github.com/user-attachments/assets/128c9b1f-534a-4bdb-9ae2-206fc692b281)

If you press the first get method all the methods having the same doc will expand at the same time:

![image](https://github.com/user-attachments/assets/ab0219a3-a40a-4459-a77d-10ee5787b683)

![image](https://github.com/user-attachments/assets/eb6d8336-91e2-4b34-b94e-c7c6267f356b)

It should raise a ValidationError with the proposed fixed as follows:

![image](https://github.com/user-attachments/assets/8d9022a2-a204-46a1-950b-f33fc60bb412)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet