-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove built-in rope_rename
plugin
#515
Remove built-in rope_rename
plugin
#515
Conversation
This functionality is better served by the pylsp-rope plugin. Resolves: python-lsp#255
That would be a major version bump, right? Some downstreams depend on the rope rename support being there by default. |
Yes, I should think so. This PR relates to this comment from @ccordoba12 who I trust will decide when this could be considered for release with the appropriate version bump. |
A couple of questions:
|
> That would be a major version bump, right? Some downstreams depend on the rope rename support being there by default.
A couple of questions:
* Do you know which projects depend on it?
* I think there shouldn't be major issues for downstream projects because the only thing they should be doing is enabling `rope_rename` with a config option, which would stop working. But renames could be handled by enabling `jedi_rename` instead.
if it was enabled by default, then could you also make this refactor keep 'rename' feat be enabled by default? though it would be on 'jedi'.
// since perhaps someone maybe no 'rope' installed, or not like (or cannot) to install 'rope'.
…--
shane.xb.qian
|
No, it is not enabled by default python-lsp-server/pylsp/plugins/rope_rename.py Lines 15 to 17 in d726905
and not even listed as a configuration option in CONFIGURATION.md which is what brought it to my attention. Edit: Nor for that matter is |
|
Agreed. That's why I think if we make a note in the release notes about the removal of that plugin and that people can switch to
That would be great, thanks @lieryan!
Ok, so that means you probably need to have this in a published release of |
rope_rename
plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help with this @doolio!
No problem. I presume nothing further is required from me with this PR? |
Nop, it isn't. |
This functionality is better served by the pylsp-rope plugin.
Fixes #255