Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scenario description to JSON and add test for JSON correctly populating the description from a feature #749

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

jsa34
Copy link
Collaborator

@jsa34 jsa34 commented Dec 1, 2024

Adds scenario description to json output.

The test for the json output didn't check the feature description field was populated. I have added a value here so we can be sure this is being set.

Resolves #351

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (be83407) to head (02d7c3f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files          55       55           
  Lines        2244     2244           
  Branches      246      246           
=======================================
  Hits         2156     2156           
  Misses         53       53           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsa34 jsa34 changed the title Add test for json correctly populating the description from a feature Add scenario description to JSON and add test for JSON correctly populating the description from a feature Dec 1, 2024
youtux
youtux previously approved these changes Dec 1, 2024
Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, mind adding a changelog entry?

@youtux youtux force-pushed the test-feature-description-in-json branch from 86fe904 to 02d7c3f Compare December 2, 2024 20:52
@youtux youtux enabled auto-merge December 2, 2024 20:52
@youtux youtux merged commit 6a2b2fb into master Dec 2, 2024
16 of 18 checks passed
@youtux youtux deleted the test-feature-description-in-json branch December 2, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description in scenario
2 participants