Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that step args and example params with the same name do not redefine each other #745

Merged
merged 7 commits into from
Dec 2, 2024

Conversation

jsa34
Copy link
Collaborator

@jsa34 jsa34 commented Nov 29, 2024

Resolves #177

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (6a2b2fb) to head (633ee28).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   96.07%   96.08%   +0.01%     
==========================================
  Files          55       55              
  Lines        2244     2250       +6     
  Branches      246      246              
==========================================
+ Hits         2156     2162       +6     
  Misses         53       53              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forgot to submit the review

tests/feature/test_outline.py Outdated Show resolved Hide resolved
@jsa34 jsa34 changed the title Add test to assert that issue 177 is resolved. Test that step args and example params with the same name do not redefine each other Dec 1, 2024
youtux
youtux previously approved these changes Dec 2, 2024
Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some optional comments if you feel like fixing them, otherwise feel free to merge

@youtux youtux merged commit 86a956e into master Dec 2, 2024
18 checks passed
@youtux youtux deleted the test-177 branch December 2, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict between Scenario Outline parameters and other steps' parameters
2 participants