Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to assert that issue 389 is resolved. #744

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 48 additions & 3 deletions tests/args/test_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_string_steps_dont_take_precedence(pytester):
pytester.makeconftest(
textwrap.dedent(
"""
from pytest_bdd import given, when, then, parsers
from pytest_bdd import given, when, then
from pytest_bdd.utils import dump_obj


Expand All @@ -95,8 +95,7 @@ def _():
pytester.makepyfile(
textwrap.dedent(
r"""
import pytest
from pytest_bdd import parsers, given, when, then, scenarios
from pytest_bdd import parsers, given, scenarios
from pytest_bdd.utils import dump_obj

scenarios("arguments.feature")
Expand All @@ -114,3 +113,49 @@ def _(value):

[which] = collect_dumped_objects(result)
assert which == "re"


def test_same_name_for_step_arg_and_example_parameter(pytester):
"""Test that using the same name for step arg and example parameter as intended."""
jsa34 marked this conversation as resolved.
Show resolved Hide resolved
pytester.makefile(
".feature",
step_args_examples_params=textwrap.dedent(
"""\
Feature: Test feature

Scenario Outline: Scenario 1
Given Action "A" is taken
Then Some other action "<action>" is taken

Examples: Actions
| action |
| B |
"""
),
)
pytester.makepyfile(
textwrap.dedent(
"""
from pytest_bdd import scenarios, given, then, parsers

scenarios('.')


@given(parsers.parse('Action "{action}" is taken'))
def take_action1(action):
print(f'take_action1:{action}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use dumb_obj and collect_dumped_obj instead, I made them for exactly this purpose



@then(parsers.parse('Some other action "{action}" is taken'))
def take_action2(action):
print(f'take_action2:{action}')

"""
)
)

result = pytester.runpytest("-s")
result.assert_outcomes(passed=1)

result.stdout.fnmatch_lines(["*take_action1:A*"])
result.stdout.fnmatch_lines(["*take_action2:B*"])
Loading