Fix for #25: CellDiff2Vec doesn't terminate #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue appears to be from complexes that are too small. The
_run_diffusion_process
method runs a while loop, comparing the number of nodes todiffusion_cover
(which defaults to 80). For graphs with fewer than 80 nodes, this loop never terminates:To solve this I added an exception to
CellDiff2Vec
inside thefit
method:I didn't find any more issues with graphs meeting this requirement.
edit: Thank you Florian for spotting the issue with PathComplex! I reverted this change with rebase now.