fix: where_mpv checks for mpv than ANI_CLI_PLAYER

[71zenith]

Pull Request Template

Type of change

• Bug fix
• Feature
• Documentation update

Description

ramble here

Checklist

• any anime playing
• bumped version

---

• next, prev and replay work
• -c history and continue work
• -d downloads work
• -s syncplay works
• -q quality works
• -v vlc works
• -e select episode works
• -S select index works
• -r range selection works
• --skip ani-skip works
• --skip-title ani-skip title argument works
• --no-detach no detach works
• --dub and regular (sub) mode both work
• all providers return links (not necessarily on a single anime, use debug mode to confirm)

---

• -h help info is up to date
• Readme is up to date
• Man page is up to date

Additional Testcases

• The safe bet: One Piece
• Episode 0: Saenai Heroine no Sodatekata ♭
• Unicode: Saenai Heroine no Sodatekata ♭
• Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

[Derisis13]

Tested on linux against no mpv, flatpak mpv and system mpv. It works all the time

[71zenith]

Would be safer to have one test against mac to be sure. @port19x ?

[71zenith]

known issue for parity with discord
vlc wont work with --vlc/-v only ANI_CLI_PLAYER=vlc works due to early exit if mpv isnt found

[port19x]

I'm pretty sure this will never fail, regardless of installed player or not

[71zenith]

does it work as expected on mac?

[port19x]

To further comment on the control flow here:

1. Plattform Detection
2. Either where_iina or where_mpv run. I'm going with where_iina here.
3. where_iina checks of the iina-cli path (the out-of-band installation, not with homebrew)
   4a. if it finds it, it returns sth matching IINA
   4b. if it does not, it returns the string "iina"
4. We get to the case $player_function in
   6a. if 4a, dependency check has already been performed and is thus skipped
   6b. if 4b, dep_ch iina is executed, failing if not found

[port19x]

Finally catching the shfmt thingy again 😅

[port19x]

I'll check on mac now

[port19x]

Can confirm working on mac