Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial logger support #1370

Merged
merged 7 commits into from
Aug 26, 2024
Merged

feat: initial logger support #1370

merged 7 commits into from
Aug 26, 2024

Conversation

71zenith
Copy link
Collaborator

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@71zenith 71zenith linked an issue Jun 14, 2024 that may be closed by this pull request
@71zenith
Copy link
Collaborator Author

@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature

@justchokingaround
Copy link
Collaborator

:/

@port19x
Copy link
Collaborator

port19x commented Jun 21, 2024

@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature

That's configured by the distro, on arch I still have logs from march.
I'd say let's proceed

@71zenith
Copy link
Collaborator Author

i'd like someone to test this on mac
@justchokingaround free?

@port19x
Copy link
Collaborator

port19x commented Jun 21, 2024

I have a m1 macbook air that I bought used like 2 weeks ago.
I can do the testing if I remember

@71zenith
Copy link
Collaborator Author

@port19x did u test?

@port19x
Copy link
Collaborator

port19x commented Jun 25, 2024

I didn't forget to check, but I forgot this is already done, since it's still a draft PR.
I was confused by your inactivity.
Will test later today

@port19x port19x marked this pull request as ready for review June 25, 2024 08:45
@port19x
Copy link
Collaborator

port19x commented Jun 26, 2024

Not quite there yet. Ani-cli -l hangs
Screenshot 2024-06-26 at 07 28 55

@71zenith
Copy link
Collaborator Author

can u check the docs to see how to print the logs. its hard for me to rely on stack overflow and random forums

@port19x
Copy link
Collaborator

port19x commented Jun 26, 2024

Yeah, but might not get to it today

@port19x
Copy link
Collaborator

port19x commented Jul 1, 2024

I had to take care of an elephant this weekend.
I'll see that I get this done sometime this week.

the elephant in question

@CoolnsX
Copy link
Collaborator

CoolnsX commented Jul 1, 2024

I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.

the elephant in question

Noice, well it's a great language, and it will be like a stain on ur life 🙃

ani-cli Outdated Show resolved Hide resolved
@port19x
Copy link
Collaborator

port19x commented Jul 7, 2024

While macs logger does accept a -t argument, it's broken.
source
Since almost nothing uses logger on mac, we can just search for logger

@port19x
Copy link
Collaborator

port19x commented Jul 16, 2024

Let's merge this after the other two PRs that are currently open

@port19x
Copy link
Collaborator

port19x commented Jul 29, 2024

Given that #1372 has stalled, I'd like to merge this sometime this week.
Ideally after dealing with the two plattform refinements for steamdeck and mac os

@port19x
Copy link
Collaborator

port19x commented Aug 20, 2024

Closes #1374

@port19x port19x linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after #1398

@71zenith
Copy link
Collaborator Author

finally

@port19x port19x merged commit 2f40d6a into master Aug 26, 2024
10 checks passed
@port19x port19x deleted the add_logger branch August 26, 2024 13:46
@port19x
Copy link
Collaborator

port19x commented Aug 26, 2024

Github release coming up a little later, gotta make time to write release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arm64 Support/Package manager binaries log anime playback
4 participants