-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial logger support #1370
Conversation
@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature |
:/ |
That's configured by the distro, on arch I still have logs from march. |
i'd like someone to test this on mac |
I have a m1 macbook air that I bought used like 2 weeks ago. |
@port19x did u test? |
I didn't forget to check, but I forgot this is already done, since it's still a draft PR. |
can u check the docs to see how to print the logs. its hard for me to rely on stack overflow and random forums |
Yeah, but might not get to it today |
Noice, well it's a great language, and it will be like a stain on ur life 🙃 |
While macs |
Let's merge this after the other two PRs that are currently open |
Given that #1372 has stalled, I'd like to merge this sometime this week. |
Closes #1374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge after #1398
finally |
Github release coming up a little later, gotta make time to write release notes |
Pull Request Template
Type of change
Description
ramble here
Checklist
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work-h
help info is up to dateAdditional Testcases