Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly closes escape sequence in message 'Checking dependencies…' #1272

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

ochaton
Copy link
Contributor

@ochaton ochaton commented Feb 3, 2024

Pull Request Template

Type of change

  • Bug fix

Description

Hi, there! I've caught annoying UI bug on zsh when line "Checking dependencies..." is printed to stdout.

Before this patch it looks like this:

❯ ani-cli 'FLCL'
Checking dependencies...
                        [0m%

Symbol "\n" must be printed after resetting styles (or before them). And this patch is only about that:

❯ ./ani-cli 'FLCL'
Checking dependencies...

For maintaners

I am able to check basic functionality only on macos zsh and bash, I don't think that this patch somehow disturbes core functionality of the ani-cli.

If needed, I might bump patch version too, but I would better leave it for maintainers.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@ochaton ochaton requested a review from Derisis13 as a code owner February 3, 2024 16:52
@port19x port19x merged commit 08aff13 into pystardust:master Feb 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants