Skip to content

Commit

Permalink
fix(crd-gen): use correct description for 'spec.indicator.bool_gauge.…
Browse files Browse the repository at this point in the history
…grouping'

Signed-off-by: Sebastian Gaiser <[email protected]>
  • Loading branch information
sebastiangaiser committed Oct 29, 2024
1 parent 1e0a1ed commit b0bf752
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ spec:
successful.
properties:
grouping:
description: Total is the metric that returns how many requests there are in total.
description: Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
items:
type: string
type: array
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ spec:
successful.
properties:
grouping:
description: Total is the metric that returns how many requests there are in total.
description: Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
items:
type: string
type: array
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ spec:
successful.
properties:
grouping:
description: Total is the metric that returns how many requests there are in total.
description: Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
items:
type: string
type: array
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"description": "BoolGauge is the indicator that measures whether a boolean gauge is\nsuccessful.",
"properties": {
"grouping": {
"description": "Total is the metric that returns how many requests there are in total.",
"description": "Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.",
"items": {
"type": "string"
},
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/api/v1alpha1/servicelevelobjective_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ type BoolGaugeIndicator struct {
Query `json:",inline"`

// +optional
// Total is the metric that returns how many requests there are in total.
// Grouping allows an SLO to be defined for many SLI at once, like HTTP handlers for example.
Grouping []string `json:"grouping"`
}

Expand Down

0 comments on commit b0bf752

Please sign in to comment.