Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Replace deprecated macos-12 with macos-13 #12951

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 3, 2024

macOS12 runner image
We are beginning the deprecation process for the macOS 12 runner image, which allows us to balance our fleet capacity ahead of our upcoming macOS 15 launch. This image will be fully retired by the December 3rd, 2024. We recommend updating workflows to use macos-14, macos-13, or macos-latest.

https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

  • macos-12 and macos-13 are Intel
  • macos-14 is M1 and the same as macos-latest (although macos-15 will become macos-latest in the near future)

We currently test macos-12 (Intel) and macos-latest (M1), so replace macos-12 with macos-13 to retain Intel + M1 testing.

@ichard26 ichard26 added the skip news Does not need a NEWS file entry (eg: trivial changes) label Sep 3, 2024
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned to address this at some point, but then completely forgot. Thanks! :)

@freakboy3742
Copy link
Contributor

macOS-12 builds are now taking over 3 hours, because homebrew support has been dropped, so the first step in the build involves compiling llvm and rust from scratch. The following message appears in the build logs:

Run DEPS=breezy
/usr/local/bin/svn
Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

@freakboy3742
Copy link
Contributor

@hugovk FYI the test failure you're seeing here is corrected by #12964.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

@hugovk
Copy link
Contributor Author

hugovk commented Oct 8, 2024

And CI is green :)

@jezdez jezdez merged commit 93fa89c into pypa:main Oct 8, 2024
34 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting merge skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants