-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy multi-platform images #1412
Draft
messense
wants to merge
2
commits into
pypa:main
Choose a base branch
from
messense:multi-platform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,3 +73,27 @@ jobs: | |
env: | ||
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} | ||
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} | ||
|
||
publish_multi_platform: | ||
name: Publish Multi-platform Images | ||
# if: github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'pypa/manylinux' | ||
runs-on: ubuntu-latest | ||
needs: build_manylinux | ||
steps: | ||
- name: Wait for Travis CI | ||
uses: fountainhead/[email protected] | ||
id: wait-for-travis | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
checkName: Travis CI - Branch | ||
ref: ${{ github.event.pull_request.head.sha || github.sha }} | ||
intervalSeconds: 10 | ||
timeoutSeconds: 3600 | ||
|
||
- name: Deploy | ||
if: steps.wait-for-travis.outputs.conclusion == 'success' | ||
run: ./deploy_multi_platform.sh | ||
|
||
- name: Error on failure | ||
if: steps.wait-for-travis.outputs.conclusion != 'success' | ||
run: exit 1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
#!/bin/bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: write the script to actually create the multi-platform docker manifest. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe if this was a single step, the workflow could be re-run with failing steps only. This would require a manual action though hence I still prefer to have a separate workflow triggered on check updates if possible (only need to worry about Travis CI mostly in that case).