Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break ModelBuilder into smaller classes #1467

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Feb 4, 2025

Description

Splitting the original ModelBuilder into base class which then supports ModelBuilder and RegressionModelBuilder

Work in progress. Likely very broken at the moment

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1467.org.readthedocs.build/en/1467/

@github-actions github-actions bot added CLV MMM tests ModelBuilder Related to the ModelBuilder class and its children customer choice Related to customer choice module labels Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.04%. Comparing base (0eb7841) to head (e9f6f5c).

Files with missing lines Patch % Lines
pymc_marketing/model_builder.py 78.12% 28 Missing ⚠️
pymc_marketing/clv/models/basic.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0eb7841) and HEAD (e9f6f5c). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (0eb7841) HEAD (e9f6f5c)
11 6
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1467       +/-   ##
===========================================
- Coverage   94.68%   74.04%   -20.65%     
===========================================
  Files          50       50               
  Lines        5457     5482       +25     
===========================================
- Hits         5167     4059     -1108     
- Misses        290     1423     +1133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -165,55 +163,13 @@ def _fit_DEMZ(self, **kwargs) -> az.InferenceData:
return pm.sample(step=pm.DEMetropolisZ(), **sampler_config)

@classmethod
def load(cls, fname: str):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1356 should be considered for the load method replacing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV customer choice Related to customer choice module MMM ModelBuilder Related to the ModelBuilder class and its children tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants