Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when budgets_to_optimize are specified #1440

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

ricardoV94
Copy link
Contributor

@ricardoV94 ricardoV94 commented Jan 27, 2025

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (e4a2664) to head (83b3ac1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mmm/budget_optimizer.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
- Coverage   94.55%   94.54%   -0.02%     
==========================================
  Files          50       50              
  Lines        5422     5423       +1     
==========================================
  Hits         5127     5127              
- Misses        295      296       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the tests label Jan 27, 2025
@cetagostini
Copy link
Contributor

Solving bug on #1439

Modifying to pass test.

@ricardoV94
Copy link
Contributor Author

I like kwarg only arguments :(

@wd60622
Copy link
Contributor

wd60622 commented Jan 27, 2025

Closes #1439

@wd60622 wd60622 linked an issue Jan 27, 2025 that may be closed by this pull request
@cetagostini cetagostini merged commit dd2ff1f into pymc-labs:main Jan 27, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MMM optimizer tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on budget optimizer
3 participants